Don't allocate for zero- or one-stream batches in Task::batch - #3414
Open
edwloef wants to merge 1 commit into
Open
Don't allocate for zero- or one-stream batches in Task::batch#3414edwloef wants to merge 1 commit into
Task::batch#3414edwloef wants to merge 1 commit into
Conversation
edwloef
force-pushed
the
task-batch-empty
branch
from
August 9, 2026 07:27
5d00573 to
1938a8d
Compare
edwloef
changed the title
Task::batchTask::batch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rather trivial optimization that saves on allocating when batching an iterator of zero or one non-none tasks.
I heavily abuse
Task::batchto compose messages, and it not adding unnecessary heap allocations anddyn-indirection would make me feel a lot less bad about it 😆